[Differential] [Request, 63 lines] D2492: [Panel Containment] Cleanup

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  - When creating the applet container set as many properties initially as you can (today I learned: Qt.binding works in there too)
  - Use Qt.binding for configure action visibility/enabledness
  - Cache array lengths and lookups in loops (unfortunately QML list basic type behaves widely different from a JS Array and has none of its fancy "some" and "forEach" functions)
  - Remove unused variables

TEST PLAN
  Panel still works.
  Verified the binding with HiddenStatus still works, ie. pager is invisible with just one virtual desktop but shows up when panel controller opens.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2492

AFFECTED FILES
  containments/panel/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160818/b096bfab/attachment.html>