Review Request 128708: [ContainmentView] Show panel when ui becomes ready

Marco Martin notmart at gmail.com
Thu Aug 18 11:34:55 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128708/#review98464
-----------------------------------------------------------


Ship it!




Ship It!

- Marco Martin


On Aug. 18, 2016, 11:34 a.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128708/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2016, 11:34 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> The code already had logic in there but since ui ready is usually emitted later the client (in this case plasmashell) had to manually show the panels and would usually show them when they're not ready yet.
> 
> 
> Diffs
> -----
> 
>   src/plasmaquick/containmentview.cpp adffb0c 
> 
> Diff: https://git.reviewboard.kde.org/r/128708/diff/
> 
> 
> Testing
> -------
> 
> Together with https://phabricator.kde.org/D2475 I now get a glitch-free panel startup in plasma
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160818/14bf4e76/attachment.html>


More information about the Plasma-devel mailing list