[Differential] [Updated] D2478: make kcolorschemeditor desktop entry spec compliant and refine it

sitter (Harald Sitter) noreply at phabricator.kde.org
Thu Aug 18 10:50:05 UTC 2016


sitter marked an inline comment as done.
sitter added a comment.


  Dump from IRC
  
  > [12:18] <sitter> ochurlaud: why is kcolorschemeeditor a standalone application if you don't use it as such?
  >  [12:25] <ochurlaud> sitter: It can be used at such
  >  [12:26] <ochurlaud> but you might want to access it from the colors kcm, and until now, i didn't find a way to reload the kcm after creating a new scheme
  >  [12:27] <ochurlaud> maybe i would need to send a DBus signal or something...
  >  [12:27] <sitter> ochurlaud: so the plan is to not use SchemeEditorDialog directly but run the standalone application from the KCM?
  >  [12:28] <ochurlaud> sitter, if it  is possible it is the plan
  >  [12:28] <ochurlaud> the idea is also that notmart is creating a theme creation tool
  >  [12:28] <ochurlaud> and a color scheme creation tool would be needed: it should finally move to plasma-sdk or something
  >  [12:29] <sitter> ah yes, cool then
  >  [12:30] <sitter> ochurlaud: also, yeah you'll probably need to send a dbus signal to the editor to have it load a different scheme
  >  [12:30] <ochurlaud> sitter: well but don't expect it too early... :S
  >  [12:31] <sitter> ochurlaud: no no. I was just perplexed by there being an application but the application not actually being used by the KCM :)
  >  [12:36] <ochurlaud> sitter: see Thomas comments on https://phabricator.kde.org/D2409 about the context
  >  [12:36] <sKreamer> Diff 2409 "Update Color KCM" [Closed] https://phabricator.kde.org/D2409
  >  [12:36] <ochurlaud> It was the first iteration. Now that we have a standalone app, we can play with it so that it becomes better without breaking the kcm
  >  [12:37] <ochurlaud> sitter: ok, then I accept your change, and we'll undo the nodisplay (maybe) in next iteration
  >  [12:37] <sitter> ochurlaud: right now I think nodisplay is the way to go. That being said, I think even with it being a proper application it would be weird to have it in the menu. Even if it doesn't look like a KCM anymore, it still is effectively a settings app, which we all bundle into systemsettings
  >  [12:38] <sitter> but yeah, that's a discussion to be had at a later time

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2478

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, bshah, ochurlaud
Cc: ochurlaud, bshah, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160818/a3d7e1b8/attachment.html>


More information about the Plasma-devel mailing list