[Differential] [Updated] D2478: make kcolorschemeditor desktop entry spec compliant and refine it

[ochurlaud (Olivier Churlaud)]

ochurlaud added a comment.


  In https://phabricator.kde.org/D2478#46347, @sitter wrote:
  
  > Pulling in @ochurlaud
  >
  > The NoDisplay remark from Bhushan got me wondering how the KCM actually starts the app. And it turns out that it doesn't.
  >
  >   SchemeEditorDialog* dialog = new SchemeEditorDialog(path, this);
  >   dialog->setModal(true);
  >   dialog->show();
  >   
  >
  > Which is now raising the question why kcolorschemeditor was made a standalone application to begin with seeing as it adds no value?
  
  
  I would not put that in no-display but rather so that it goes in the tools or something similar

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2478

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, bshah, ochurlaud
Cc: ochurlaud, bshah, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160818/260adf44/attachment.html>