Review Request 128707: Add support for captive portals
Sebastian Kügler
sebas at kde.org
Thu Aug 18 10:24:01 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128707/#review98459
-----------------------------------------------------------
kded/portalmonitor.h (line 43)
<https://git.reviewboard.kde.org/r/128707/#comment66338>
QScopedPointer?
kded/portalmonitor.cpp (line 47)
<https://git.reviewboard.kde.org/r/128707/#comment66342>
if it's Portal, and m_view has been created, maybe it should be shown?
kded/portalmonitor.cpp (line 51)
<https://git.reviewboard.kde.org/r/128707/#comment66339>
Why? Shouldn't we let the window manager decide this? On my 4K screen, it doesn't make sense to maximize, for example.
kded/portalmonitor.cpp (line 52)
<https://git.reviewboard.kde.org/r/128707/#comment66340>
parent the lambda to this
kded/portalmonitor.cpp (line 56)
<https://git.reviewboard.kde.org/r/128707/#comment66344>
nullptr, no need to use the Qt macro
kded/portalmonitor.cpp (line 64)
<https://git.reviewboard.kde.org/r/128707/#comment66345>
parent to this
kded/service.cpp (line 49)
<https://git.reviewboard.kde.org/r/128707/#comment66346>
coding style, PortalMonitor *portalMonitor
(should be at least consistent for new code)
kded/service.cpp (line 60)
<https://git.reviewboard.kde.org/r/128707/#comment66347>
nullptr
- Sebastian Kügler
On Aug. 18, 2016, 10:15 a.m., Jan Grulich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128707/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2016, 10:15 a.m.)
>
>
> Review request for Network Management, Plasma, KDE Usability, and Lamarque Souza.
>
>
> Bugs: 365417
> http://bugs.kde.org/show_bug.cgi?id=365417
>
>
> Repository: plasma-nm
>
>
> Description
> -------
>
> Adds portal monitor to our kded module, which checks NetworkManager connectivity. If the value gets changed to NM_CONNECTIVITY_PORTAL (means we are behind a captive portal), then we open a QWebEngineView trying to load "http://kde.org" page which is supposed to be redirected to the captive portal page. Once user logs in and url changes, we re-check the connectivity again and close the web view if we are no longer behind the captive portal.
>
>
> Diffs
> -----
>
> CMakeLists.txt a27c1f2
> kded/CMakeLists.txt 1f0613e
> kded/portalmonitor.h PRE-CREATION
> kded/portalmonitor.cpp PRE-CREATION
> kded/service.cpp 18ffd41
>
> Diff: https://git.reviewboard.kde.org/r/128707/diff/
>
>
> Testing
> -------
>
> Tested with three different captive portals and it worked perfectly.
>
>
> Thanks,
>
> Jan Grulich
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160818/6926226e/attachment-0001.html>
More information about the Plasma-devel
mailing list