Review Request 128703: [kcm_mouse] Sync KDE4 config after writing the KF5 settings, not before
Wolfgang Bauer
wbauer at tmo.at
Thu Aug 18 07:43:35 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128703/
-----------------------------------------------------------
(Updated Aug. 18, 2016, 9:43 vorm.)
Review request for Plasma.
Changes
-------
Found another (older) bug report that should get fixed by this.
Bugs: 348254 and 367074
https://bugs.kde.org/show_bug.cgi?id=348254
https://bugs.kde.org/show_bug.cgi?id=367074
Repository: plasma-desktop
Description
-------
Kdelibs4SharedConfig::syncConfigGroup() reads the settings from the corresponding KF5 config files.
If we don't write them before, it will use the previous settings.
Also fix Kdelibs4SharedConfig::syncConfigGroup() to read the settings from the passed config file instead of always kdeglobals.
Diffs
-----
kcms/input/mouse.cpp 3dbda19
kcms/migrationlib/kdelibs4config.h a2f4139
Diff: https://git.reviewboard.kde.org/r/128703/diff/
Testing
-------
Change between single-click and double-click (or some other setting like right-handed/left-handed) and apply.
The KDE4 settings are written correctly now, they are the same as for KF5.
Before, the old settings (before clicking Apply) were saved to KDE4, the Mouse settings in kcminputrc were not written at all.
Thanks,
Wolfgang Bauer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160818/d7023feb/attachment-0001.html>
More information about the Plasma-devel
mailing list