[Differential] [Request, 28 lines] D2468: [platforms/hwcomposer] Reset old brightness when turning screen back on
bshah (Bhushan Shah)
noreply at phabricator.kde.org
Wed Aug 17 09:21:24 UTC 2016
bshah created this revision.
bshah added reviewers: Plasma on Wayland, broulik, graesslin.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.
REVISION SUMMARY
Now powerdevil can adjust brightness using leds subsystem, however, kwin
as well sets brightness to 0 for turning off screen and 0xff when
turning screen back on. This resets the brightness set by the powerdevil
to 100%.
As a solution now kwin listens to brightnessChanged dbus signal of
brightnesscontrol and book-keeps the changed brightness, if screen is
turned off it sets brightness to 0 and when turning screen on, it resets
to old brightness.
If powermanagement service doesn't appear on dbus by default it restores
100% brightness.
TEST PLAN
Appearantly this still doesn't work as-it-is on phone, because powerdevil
doesn't emit brightnessChanged dbus signal because of bug in the driver of
backlight control, driver doesn't seem to trigger uevents for changes in
backlight. But with hack in powerdevil to emit brightnessChanged when setting
brightness, this works
REPOSITORY
rKWIN KWin
BRANCH
bshah/hwcomposer-restore-brightness (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D2468
AFFECTED FILES
plugins/platforms/hwcomposer/hwcomposer_backend.cpp
plugins/platforms/hwcomposer/hwcomposer_backend.h
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: bshah, #plasma_on_wayland, broulik, graesslin
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160817/94fdb187/attachment.html>
More information about the Plasma-devel
mailing list