[Differential] [Request, 109 lines] D2465: [kded] correctly restore lidOpened configuration on startup
sebas (Sebastian Kügler)
noreply at phabricator.kde.org
Wed Aug 17 03:34:48 UTC 2016
sebas created this revision.
sebas added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
When shutting down the machine (or kded5, really) with the lid closed
will leave a config with the laptop panel disabled, and also a config
with the same id, but _lidOpened appended. The latter is the config that
is restored when the lid is opened again. When the lid is opened while
kded wasn't running (shut down), the config with the panel disabled is
restored.
We do want to restore the _lidOpened config, so check if it exists, and
if it does, move it to the configId to have it restored.
This effectively avoids a disabled laptop panel after the laptop has
been shut down with an external monitor connected and the lid closed.
BUG:353029
TEST PLAN
- added autotest for this case
- reproduced bug by killing kded with an external output connected and the laptop lid closed, after opening the lid, kded would correctly enable the laptop display on startup
REPOSITORY
rKSCREEN KScreen
BRANCH
sebas/lidopeninit
REVISION DETAIL
https://phabricator.kde.org/D2465
AFFECTED FILES
kded/daemon.cpp
kded/serializer.cpp
kded/serializer.h
tests/kded/serializertest.cpp
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: sebas, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160817/98bbc5c1/attachment.html>
More information about the Plasma-devel
mailing list