[Differential] [Requested Changes To] D2449: small utility to create L&F packages

[davidedmundson (David Edmundson)]

davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> davidedmundson wrote in lnflogic.cpp:155
> That's the wrong group name. 
> It should be TabBox.
> 
> (and if this is copy pastad from somewhere, then fix that too.)

Edit: This kwin saving stuff is *still* wrong.

In systemCG (kwinrc) it is "TabBox".
However, in the LnF it is "WindowSwitcher."

You "fixed" the wrong one.

You are also missing DesktopSwitcher.

I'll just write the code for you:

  systemCG = KConfigGroup(KSharedConfig::openConfig(QStringLiteral("kwinrc")), "TabBox");
  defaultsConfigGroup = KConfigGroup(&defaultsConfigGroup, "WindowSwitcher");
  defaultsConfigGroup.writeEntry("LayoutName", systemCG.readEntry("LayoutName", QStringLiteral("org.kde.breeze.desktop")));
  
  defaultsConfigGroup = KConfigGroup(&defaultsConfigGroup, "DesktopSwitcher");
  defaultsConfigGroup.writeEntry("LayoutName", systemCG.readEntry("DesktopLayout", QStringLiteral("org.kde.breeze.desktop")))

REPOSITORY
  rPLASMASDK Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D2449

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160816/09ce18dd/attachment.html>