[Differential] [Commented On] D2462: Remove deprecated code in kscreenlocker theme

davidedmundson (David Edmundson) noreply at phabricator.kde.org
Tue Aug 16 11:34:32 UTC 2016


davidedmundson added inline comments.

INLINE COMMENTS

> graesslin wrote in LockScreen.qml:32
> this change I don't understand. It's not described in the change.

It's in the original commit message that got hidden.

This code existed in case you ran the new theme with an old plasma.

Useful for a while but it doesn't make sense to keep that forever. 
I don't know what our policy on skipped upgrades is. (i.e going 5.3 -> 5.6)

I'm not particularly desperate to kill it, I just was doing some lock screen changes and had no intention of properly testing this bit.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2462

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, graesslin
Cc: mart, graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160816/e59703fd/attachment.html>


More information about the Plasma-devel mailing list