[Differential] [Commented On] D2365: Add failing test case for selected filter from mimetype

[elvisangelaccio (Elvis Angelaccio)]

elvisangelaccio added a comment.


  In https://phabricator.kde.org/D2365#45684, @dfaure wrote:
  
  > The thing is, mimetype filters should be preferred above name filters. So the bug is in QFileDialog::selectMimeTypeFilter which "falls back" to selectNameFilter. Instead it should call some selectInitiallySelectedMimeTypeFilter in the options, like selectNameFilter does with setInitiallySelectedNameFilter, and QPlatformFileDialogHelper is missing a selectMimeTypeFilter.
  >
  > The fallback to selectNameFilter should only happen if d->usingWidgets() or d->selectMimeTypeFilter_sys() (to be added) fails.
  >
  > Feel like making a patch for Qt ?
  
  
  Sounds like something that I can try to do at Akademy :)
  In the meantime, does this test still makes sense? Or maybe (if we are going to patch QFileDialog) would be better to add a new `QFileDialog::selectedMimeTypeFilter()`? (and use it instead of `selectedNameFilter()` in the last QCOMPARE)

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D2365

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, graesslin, dfaure
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160815/639db49d/attachment.html>