[Differential] [Accepted] D2448: use dbus interface to switch shell l&f

[davidedmundson (David Edmundson)]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kcm.cpp:33
>  #include <QProcess>
> +#include <QFile>
>  #include <QQuickWidget>

unused

> kcm.cpp:258
> +
> +    QDBusConnection::sessionBus().asyncCall(message);
> +

if you're not going to handle the reply at all

.call(message, QDBus::NoBlock) 
is better

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  phab/lnfshellswitchkcm

REVISION DETAIL
  https://phabricator.kde.org/D2448

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160815/a718523a/attachment-0001.html>