[Differential] [Updated] D2399: New new SDDM theme

[davidedmundson (David Edmundson)]

davidedmundson added inline comments.

INLINE COMMENTS

> bshah wrote in KeyboardButton.qml:13
> I wonder if it ever worked to translate those in SDDM? Given KDeclarative takes care of loading translation domain IIRC.

It used to work.
We don't have the i18n domain set because we're being loaded by SDDM, however the i18nd explicitly sets the domain to use.

This has been fixed by https://phabricator.kde.org/rPLASMAWORKSPACE0ece53786e1a7ee37f4ce5e01172673b43a1407c in plasma-workspace master.

No changes to this patch are needed.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2399

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: bshah, mart, apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160815/7b5b8622/attachment.html>