Review Request 128660: Add an optional reveal password button to TextField

[Kai Uwe Broulik]

> On Aug. 15, 2016, 10:52 vorm., Kai Uwe Broulik wrote:
> > src/declarativeimports/plasmastyle/TextFieldStyle.qml, line 80
> > <https://git.reviewboard.kde.org/r/128660/diff/2/?file=474164#file474164line80>
> >
> >     Don't add units.smallSpacing if there's no actions, the padding is now uneven left and right when no buttons are present

Also, shouldn't that be a base.margins.right or sth like that?


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128660/#review98397
-----------------------------------------------------------


On Aug. 14, 2016, 10:48 nachm., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128660/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2016, 10:48 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Similar to KPasswordWidget in kwidgetaddons
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmacomponents/qml/TextField.qml c0d9155df5bb584cd3070a66c99d98465b81a5ef 
>   src/declarativeimports/plasmastyle/TextFieldStyle.qml 05ff3d542ad0de6879ec1de832b5e5d9ed33281e 
>   tests/components/textfield.qml 0a7f8886ba0552c2bb23424ee873423cc5ee0585 
> 
> Diff: https://git.reviewboard.kde.org/r/128660/diff/
> 
> 
> Testing
> -------
> 
> Updated manual test. See screenshot.
> 
> 
> File Attachments
> ----------------
> 
> Spectacle.B12253.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/08/12/b308072d-a1c2-4bd8-9405-2826fc9f4086__Spectacle.B12253.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160815/76c2c801/attachment-0001.html>