Review Request 128473: Avoid recursive calls to QPlatformTheme::createPlatformSystemTrayIcon()

[Martin Tobias Holmedahl Sandsmark]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128473/
-----------------------------------------------------------

(Updated Aug. 13, 2016, 7:31 p.m.)


Status
------

This change has been discarded.


Review request for Plasma.


Repository: plasma-integration


Description
-------

If the status notifier item host is not available, KSNI tries to create a normal QSystemTrayIcon.

The plasma platform plugin uses KSNI when it is called to create a QPlatformSystemTrayIcon.

So if the status notifier item host for any reason was unavailable, this would recursively run forever (assuming a turing machine with infinite memory).


Diffs
-----

  src/platformtheme/kdeplatformsystemtrayicon.h 6825b4d 
  src/platformtheme/kdeplatformsystemtrayicon.cpp 0e82385 
  src/platformtheme/kdeplatformtheme.cpp 5f0407c 

Diff: https://git.reviewboard.kde.org/r/128473/diff/


Testing
-------

Now it is possible to run applications that have tray icons with the plasma platform plugin even when the status notifier item host is down or unavailable.


Thanks,

Martin Tobias Holmedahl Sandsmark

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160813/eff9703c/attachment.html>