Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

[Martin Gräßlin]

> On Aug. 12, 2016, 1:31 p.m., Martin Gräßlin wrote:
> > Could someone please test, whether this works?
> > 
> >     diff --git a/shell/desktopview.cpp b/shell/desktopview.cpp
> >     index 14a25af..38c6621 100644
> >     --- a/shell/desktopview.cpp
> >     +++ b/shell/desktopview.cpp
> >     @@ -226,6 +226,7 @@ bool DesktopView::event(QEvent *e)
> >                  switch (pe->surfaceEventType()) {
> >                  case QPlatformSurfaceEvent::SurfaceCreated:
> >                      setupWaylandIntegration();
> >     +                ensureWindowType();
> >                      break;
> >                  case QPlatformSurfaceEvent::SurfaceAboutToBeDestroyed:
> >                      delete m_shellSurface;
> 
> Anthony Fieroni wrote:
>     I can't get plasmashell to work in wayland on my skylake laptop, it crashes every time.
> 
> Martin Gräßlin wrote:
>     I meant to test that on X11, not on Wayland. On Wayland I can test myself :-)
> 
> Anthony Fieroni wrote:
>     How this expect to work? Multiple calls in setFlags triggers the bug, if we remove esureWindowType at focusIn then it *should* work.
> 
> Thomas Lübking wrote:
>     The implication is probably to remove it *everywhere* else.

yep, the idea is whether the types is set correctly after surface created. If it is we can remove all other calls.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128647/#review98334
-----------------------------------------------------------


On Aug. 10, 2016, 8:28 p.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128647/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2016, 8:28 p.m.)
> 
> 
> Review request for kwin, Plasma, David Edmundson, David Rosca, and Marco Martin.
> 
> 
> Bugs: 350826 and 365014
>     https://bugs.kde.org/show_bug.cgi?id=350826
>     https://bugs.kde.org/show_bug.cgi?id=365014
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> ^^
> 
> 
> Diffs
> -----
> 
>   shell/desktopview.cpp 83866dc 
> 
> Diff: https://git.reviewboard.kde.org/r/128647/diff/
> 
> 
> Testing
> -------
> 
> 1. open 1 or more non maximized windows
> 2. make left clicks periodically between window and the desktop
> 3. desktop is raised over opened windows *sometimes*
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160812/c47ad9cc/attachment.html>