Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

Martin Gräßlin mgraesslin at kde.org
Fri Aug 12 11:31:05 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128647/#review98334
-----------------------------------------------------------



Could someone please test, whether this works?

    diff --git a/shell/desktopview.cpp b/shell/desktopview.cpp
    index 14a25af..38c6621 100644
    --- a/shell/desktopview.cpp
    +++ b/shell/desktopview.cpp
    @@ -226,6 +226,7 @@ bool DesktopView::event(QEvent *e)
                 switch (pe->surfaceEventType()) {
                 case QPlatformSurfaceEvent::SurfaceCreated:
                     setupWaylandIntegration();
    +                ensureWindowType();
                     break;
                 case QPlatformSurfaceEvent::SurfaceAboutToBeDestroyed:
                     delete m_shellSurface;

- Martin Gräßlin


On Aug. 10, 2016, 8:28 p.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128647/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2016, 8:28 p.m.)
> 
> 
> Review request for kwin, Plasma, David Edmundson, David Rosca, and Marco Martin.
> 
> 
> Bugs: 350826 and 365014
>     https://bugs.kde.org/show_bug.cgi?id=350826
>     https://bugs.kde.org/show_bug.cgi?id=365014
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> ^^
> 
> 
> Diffs
> -----
> 
>   shell/desktopview.cpp 83866dc 
> 
> Diff: https://git.reviewboard.kde.org/r/128647/diff/
> 
> 
> Testing
> -------
> 
> 1. open 1 or more non maximized windows
> 2. make left clicks periodically between window and the desktop
> 3. desktop is raised over opened windows *sometimes*
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160812/2c096ef8/attachment.html>


More information about the Plasma-devel mailing list