Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

[Thomas Lübking]

> On Aug. 12, 2016, 11:05 vorm., Anthony Fieroni wrote:
> > I can't see bug in Qt implementaion of setFlags https://code.woboq.org/qt5/qtbase/src/plugins/platforms/xcb/qxcbwindow.cpp.html#1130
> > xcb plugin bug?

Afaik the entire thing operates on an undocumented string property to carry the type, ie. at least there's no legal way to initially indicate the window type from client code.

But I don't ultimately know why the ::ensureWindowType function exists. I would have ranted around when it had been presented ;-)


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128647/#review98330
-----------------------------------------------------------


On Aug. 10, 2016, 6:28 nachm., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128647/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2016, 6:28 nachm.)
> 
> 
> Review request for kwin, Plasma, David Edmundson, David Rosca, and Marco Martin.
> 
> 
> Bugs: 350826 and 365014
>     https://bugs.kde.org/show_bug.cgi?id=350826
>     https://bugs.kde.org/show_bug.cgi?id=365014
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> ^^
> 
> 
> Diffs
> -----
> 
>   shell/desktopview.cpp 83866dc 
> 
> Diff: https://git.reviewboard.kde.org/r/128647/diff/
> 
> 
> Testing
> -------
> 
> 1. open 1 or more non maximized windows
> 2. make left clicks periodically between window and the desktop
> 3. desktop is raised over opened windows *sometimes*
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160812/5baaee26/attachment.html>