[Differential] [Commented On] D2399: New new SDDM theme

[davidedmundson (David Edmundson)]

davidedmundson added inline comments.

INLINE COMMENTS

> mart wrote in KeyboardButton.qml:13
> is this domain valid for sddm as well?

It was...though that broke when this folder was moved. Good spot.

> mart wrote in UserDelegate.qml:85
> this version you have is probably is significantly faster (and in this case i'll shut up :p)
> 
> but wouldn't look cleaner to have something along the lines:
> 
> layer.enabled: true
> 
>   layer.effect: OpacityMask {
>       maskSource: Rectangle {
>           anchors.centerIn: parent
>           width: imageWrapper.width
>           height: width
>           radius: width/2
>       }
>   }

It's a bit more complex with the white frame that has to be transparent on the inside.

So that then needs to be drawn somehow. I guess making an SVG of a circle would work.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2399

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: mart, apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160812/4b90776a/attachment.html>