Review Request 128313: useraccount icons 128 px and sorted

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128313/#review98313
-----------------------------------------------------------



Some names are now not centered under their images. Could you please either also add the same amount of spaces at the end, or change the code to strip spaces before displaying?

- Christoph Feck


On July 4, 2016, 8:23 p.m., Andreas Kainz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128313/
> -----------------------------------------------------------
> 
> (Updated July 4, 2016, 8:23 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> all user account icons are now 128px in size in addition they were renamed to get a good preview (grid layout) and a nice sorting. the svg files were changed to svgz
> 
> 
> Diffs
> -----
> 
>   kcms/useraccount/pics/Ada Lovelace.png 0fdda9f 
>   kcms/useraccount/pics/Alice in Wonderland.png 35e680a 
>   kcms/useraccount/pics/Blackbox.png 34ea61b 
>   kcms/useraccount/pics/Dragon.png f9db690 
>   kcms/useraccount/pics/Grace Hopper.png eeb51a0 
>   kcms/useraccount/pics/Green.png 3594e67 
>   kcms/useraccount/pics/Happy.png def7cbd 
>   kcms/useraccount/pics/Kati.png 6060fb2 
>   kcms/useraccount/pics/Konqui.png 1116764 
>   kcms/useraccount/pics/Leonardo da Vinci.png 6eedda1 
>   kcms/useraccount/pics/Listening.png ad9c595 
>   kcms/useraccount/pics/Logger.png 6c843ff 
>   kcms/useraccount/pics/Mahatma Gandhi.png feab431 
>   kcms/useraccount/pics/Mowgli jungle book.png ab3f4b3 
>   kcms/useraccount/pics/Notme.png 960c0f8 
>   kcms/useraccount/pics/Parley.png 33fdb84 
>   kcms/useraccount/pics/Rekonqui.png 4003e9e 
>   kcms/useraccount/pics/TV.png c46f82d 
>   kcms/useraccount/pics/User.png 6e4624b 
>   kcms/useraccount/pics/bomb.png 9ef2232 
>   kcms/useraccount/pics/sources/Ada Lovelace.svg 293bc74 
>   kcms/useraccount/pics/sources/Alice in Wonderland.svg e163c6f 
>   kcms/useraccount/pics/sources/Dragon.svg 2575e4c 
>   kcms/useraccount/pics/sources/Grace Hopper.svg 00e241f 
>   kcms/useraccount/pics/sources/Kati.svg a5a5645 
>   kcms/useraccount/pics/sources/Konqui.svg 191aa4d 
>   kcms/useraccount/pics/sources/Leonardo da Vinci.svg 2fdf2f2 
>   kcms/useraccount/pics/sources/Logger.svg 0c75a70 
>   kcms/useraccount/pics/sources/Mahatma Gandhi.svg 35cc122 
>   kcms/useraccount/pics/sources/Mowgli jungle book.svg cfd38c8 
>   kcms/useraccount/pics/sources/Parley.svg 7ad4359 
>   kcms/useraccount/pics/sources/Rekonqui.svg 4e372d9 
>   kcms/useraccount/pics/sources/User.svg 71d044d 
>   kcms/useraccount/pics/sources/blackbox.svgz d6899f1 
>   kcms/useraccount/pics/sources/bomb.svgz 771f6d2 
>   kcms/useraccount/pics/sources/green.svgz 2d43069 
>   kcms/useraccount/pics/sources/happy.svgz 7c9fc49 
>   kcms/useraccount/pics/sources/listening.svgz 7e0e5ef 
>   kcms/useraccount/pics/sources/notme.svgz 5b4a474 
>   kcms/useraccount/pics/sources/tv.svgz d666506 
> 
> Diff: https://git.reviewboard.kde.org/r/128313/diff/
> 
> 
> Testing
> -------
> 
> done.
> 
> 
> File Attachments
> ----------------
> 
> new layout
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/06/28/8605b935-8113-4d1c-a7bc-65961b2e0c25__change_your_face.png
> pic folder from /kcms/useraccount/
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/06/28/78aff0aa-1814-4f80-8e35-df69510c03c2__pics.zip
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160811/f5eed90e/attachment.html>