Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

[Thomas Lübking]

> On Aug. 10, 2016, 1:23 nachm., David Rosca wrote:
> > https://phabricator.kde.org/D2121
> 
> Anthony Fieroni wrote:
>     So why not ship it?
> 
> Sebastian Kügler wrote:
>     Did you read Martin's comments on the phab request?
> 
> Anthony Fieroni wrote:
>     I see it make sense, because it change props on focusIn before click who triggers the bug. This is correct patch to me.
> 
> Thomas Lübking wrote:
>     The bug is the sheer existence of this function which is a ridiculous workaround for Qt *silently* ignoring the window type flag.
>     
>     Removing it there will just lower the odds that plasmashell succeeds in setting the correct window type ever (along lowering the odds to do the rubbish that causes the normal type)
>     
>     The ::ensureWindowType function needs to be erased and the type set *once* explicitly after the native window is created for the window, but before it's mapped (ie. what Qt should actually do)
>     
>     Right now, this is just messing around with the symptoms.
> 
> Anthony Fieroni wrote:
>     Workaround or not this patch is a *must*.

No, the bug *should* be fixed, because of course the situation is ridiculuous.
But this patch isn't even a workaround but only shifts odds around and does nothing to actually fix the problem.

You can remove the call here as initial step, but if you stop there, you'll just face other variations of the bug afterwards - maybe even initially cause them for other users. That's what Martin objected on David's patch.

I'd however suggest to keep the discussion there. RB is afaiu not even an accepted system anymore but in shutdown mode.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128647/#review98286
-----------------------------------------------------------


On Aug. 10, 2016, 6:28 nachm., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128647/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2016, 6:28 nachm.)
> 
> 
> Review request for kwin, Plasma, David Edmundson, David Rosca, and Marco Martin.
> 
> 
> Bugs: 350826 and 365014
>     https://bugs.kde.org/show_bug.cgi?id=350826
>     https://bugs.kde.org/show_bug.cgi?id=365014
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> ^^
> 
> 
> Diffs
> -----
> 
>   shell/desktopview.cpp 83866dc 
> 
> Diff: https://git.reviewboard.kde.org/r/128647/diff/
> 
> 
> Testing
> -------
> 
> 1. open 1 or more non maximized windows
> 2. make left clicks periodically between window and the desktop
> 3. desktop is raised over opened windows *sometimes*
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160810/ecea4bff/attachment-0001.html>