[Differential] [Request, 65 lines] D2395: [Milou] Optimize and cleanup sources model

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added reviewers: Plasma, vhanda.
broulik set the repository for this revision to rMILOU Milou.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  - Simplify queryString once, rather than during every iteration
  - Foreach instead of potentially detaching range-for
  - Use reverse iterators (new in Qt 5.6) instead of Java-style iterators
  - Remove traces of begin/endInsert/RemoveRows feature - while it would be nice to not reset the model with all this sorting and merging going on it's pretty difficult to predict where an item will end up which is probably why it never got implemented. It still calculated tons of indices that went unused, so remove this and go a different route in the future

TEST PLAN
  Seems to work

REPOSITORY
  rMILOU Milou

REVISION DETAIL
  https://phabricator.kde.org/D2395

AFFECTED FILES
  lib/sourcesmodel.cpp
  lib/sourcesmodel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, vhanda
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160810/c6d711c8/attachment.html>