[Differential] [Commented On] D2330: [xrandr backend] fall back to preferred mode, fix crash

[graesslin (Martin Gräßlin)]

graesslin added inline comments.

INLINE COMMENTS

> sebas wrote in xrandrconfig.cpp:556-558
> No, this part is a bit different from the above hunk, it uses the xOutput by default, and if that is empty, falls back to kscreen's currentModeId or the preferredModeId.

but then I would reorder it. Why call toInt() and then check afterwards whether that one can work at all? I would suggest to make it if-else then

REPOSITORY
  rLIBKSCREEN KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D2330

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, dvratil, graesslin
Cc: graesslin, plasma-devel, #plasma, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160810/044e5f79/attachment-0001.html>