[Differential] [Reopened] D2325: Don't unconditionally emit buttonPressed on profile load

[oliverhenshaw (Oliver Henshaw)]

oliverhenshaw reopened this revision.
oliverhenshaw added a comment.
This revision is now accepted and ready to land.


  > I can't find any evidence about the reason this was put in there in the first place.
  
  'git blame' [1] shows that this was added for https://bugs.kde.org/show_bug.cgi?id=243618 - it should still work as intended as long as the screen detection works properly.
  The idea was that switching to a profile and then closing the lid should have the same result as closing the lid and then switching to a profile. Any exceptions are dealt with as inhibitions and will/should work exactly the same in the second case as in the first. I would suggest reverting this and perhaps updating the code comment.
  
  Or perhaps there's a better way to handle bug 243618 now?
  
  [1] with https://community.kde.org/Frameworks/GitOldHistory to graft in the old history.

REPOSITORY
  rPOWERDEVIL Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D2325

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, afiestas, #plasma, davidedmundson
Cc: oliverhenshaw, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160810/e0fe73b8/attachment.html>