Review Request 128642: Fix blatant bug in code that was pushed unreviewed

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128642/#review98262
-----------------------------------------------------------



Can we change this to use QSignalBlocker, returning and having to take care of unblocking again isn't future-proof as we have just experienced.

- Kai Uwe Broulik


On Aug. 9, 2016, 11:48 nachm., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128642/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2016, 11:48 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> commit c8fdd7ed2032b7b0664a6c9d0d56296f674abeb2 pushes a lazy fix for a
> crash, but instead just leaves all signals blocked on
> ContainmentInterface
> 
> 
> Diffs
> -----
> 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp 55d91aa9d09ee37ec523f9a16f347586db00ecd5 
> 
> Diff: https://git.reviewboard.kde.org/r/128642/diff/
> 
> 
> Testing
> -------
> 
> Read the code.
> Which apparently the previous person didn't do.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160810/eab2a8e4/attachment.html>