Review Request 128641: Fix argument type in QMetaObject invoke *NEEDS BACKPORTING TO 5.25*

Sebastian Kügler sebas at kde.org
Tue Aug 9 23:32:31 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128641/#review98253
-----------------------------------------------------------


Ship it!




Ship It!

- Sebastian Kügler


On Aug. 9, 2016, 11:04 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128641/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2016, 11:04 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and David Faure.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Commit bb70febdbe397b617e5c41aff5494fdbc185fa88 ported an argument from
> QPoint to QRectF. However, not all local invocations were updated correctly with one passing a QRect, which fails.
> 
> *NEEDS BACKPORTING TO 5.25*
> 
> 
> Diffs
> -----
> 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp 4efc1e109bbab8ef43b686be25574ed5bd66d9ce 
> 
> Diff: https://git.reviewboard.kde.org/r/128641/diff/
> 
> 
> Testing
> -------
> 
> Before: Couldn't drag applet from Widget Explorer to Desktop
> After: Can
> 
> Checked the other invocations are correct.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160809/60a9cef9/attachment-0001.html>


More information about the Plasma-devel mailing list