[Differential] [Commented On] D1989: Introduce QQuickItem to nest kwin_wayland

[graesslin (Martin Gräßlin)]

graesslin added inline comments.

INLINE COMMENTS

> kwinqml.cpp:153
> +    if (m_seat != nullptr) {
> +        m_seat->keyPressed(event->nativeScanCode() - 8);
> +    }

only do that on X11, if we are on Wayland that would be wrong. So do something like:

  const int magicOffset = KWindowSystem::isPlatformX11() ? 8 : 0;
  m_seat->keyPressed(event->nativeScanCode() - magicOffset);

And I'm glad it was the 8 issue, luckily I remembered that - having stumbled over this weirdness myself in the past.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D1989

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bdhruve, bshah, graesslin, #plasma_on_wayland
Cc: bshah, graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160809/c49496e0/attachment-0001.html>