Review Request 126131: Don't delete gl texture twice in thumbnail
David Edmundson
david at davidedmundson.co.uk
Tue Aug 9 08:37:05 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126131/
-----------------------------------------------------------
(Updated Aug. 9, 2016, 8:37 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks and Plasma.
Changes
-------
Submitted with commit 45a2f5a8286d9884fdf1161c09da5807c0528481 by David Edmundson to branch master.
Repository: plasma-framework
Description
-------
The QSGTextures are created with
window()->createTextureFromId(m_texture, QSize(w,h),
QuickWindow::TextureOwnsGLTexture));
this means we don't want to be deleting textures ourselves too, it will
be deleted when we delete the QSGTexture, which is a scoped pointer
inside our QSGNode.
BUG: 355644
REVIEW:
Diffs
-----
src/declarativeimports/core/windowthumbnail.cpp 6c46789b13411fe311c4d3fb60c690abd966cc38
Diff: https://git.reviewboard.kde.org/r/126131/diff/
Testing
-------
Thanks,
David Edmundson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160809/4f82b570/attachment.html>
More information about the Plasma-devel
mailing list