Review Request 128633: Wether nor not install the private header?

Leslie Zhai xiangzhai83 at gmail.com
Tue Aug 9 06:03:19 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128633/
-----------------------------------------------------------

(Updated 八月 9, 2016, 2:03 p.m.)


Review request for Plasma and Sune Vuorela.


Repository: prison


Description
-------

Hi Sune,

People might directly use Prison::QRCodeBarcode https://github.com/xiangzhai/qwx/blob/kf5/src/qrcodequick.cpp#L9 instead of via Prison::createBarcode

so is it able to install the private header?

Regards,
Leslie Zhai


Diffs
-----

  lib/CMakeLists.txt 95391cc 

Diff: https://git.reviewboard.kde.org/r/128633/diff/


Testing
-------

- prison/tests/test-prison
- plasma-workspace/klipper
- qwx/QRcodeQuick https://github.com/xiangzhai/qwx/blob/kf5/src/qrcodequick.h


Thanks,

Leslie Zhai

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160809/a45568b6/attachment.html>


More information about the Plasma-devel mailing list