[Differential] [Accepted] D2356: [shell] Add a dbus call to activate the "main" application launcher

mart (Marco Martin) noreply at phabricator.kde.org
Mon Aug 8 15:01:21 UTC 2016


mart accepted this revision.
mart added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> shellcorona.cpp:1640
> +                if (!applet->globalShortcut().isEmpty()) {
> +                    emit applet->activated();
> +                    return;

the way i can see it breaking is if an user has 2 menus with 2 different shortcuts (extremely unlikely and weird, but i don't get surprised by anything anymore)
 it's fine for me, just to know the case exists

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  shell-dbus-launchermenu

REVISION DETAIL
  https://phabricator.kde.org/D2356

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, hein, mart
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160808/2408e2dd/attachment.html>


More information about the Plasma-devel mailing list