Review Request 128610: Fix tests not passing, make sure we separate paths properly

Marco Martin notmart at gmail.com
Fri Aug 5 13:32:02 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128610/#review98141
-----------------------------------------------------------


Ship it!




Ship It!

- Marco Martin


On Aug. 5, 2016, 1:31 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128610/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2016, 1:31 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kpackage
> 
> 
> Description
> -------
> 
> Properly concatenate paths.
> Make sure cleanupPackage doesn't expand to other tests.
> 
> 
> Diffs
> -----
> 
>   autotests/plasmoidpackagetest.cpp 4ce5924 
>   src/kpackage/package.cpp dbecbd2 
>   src/kpackage/packagestructure.cpp b05682b 
> 
> Diff: https://git.reviewboard.kde.org/r/128610/diff/
> 
> 
> Testing
> -------
> 
> Tests pass for good now.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160805/9f6a5520/attachment.html>


More information about the Plasma-devel mailing list