Review Request 128597: support a size for adding applets
David Edmundson
david at davidedmundson.co.uk
Thu Aug 4 13:28:39 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128597/#review98103
-----------------------------------------------------------
src/scriptengines/qml/plasmoid/containmentinterface.cpp (line 248)
<https://git.reviewboard.kde.org/r/128597/#comment66073>
QSize::isNull
"Returns true if both the width and height is 0; otherwise returns false."
You're passing it QSize(-1,-1)
have you tested if it works?
- David Edmundson
On Aug. 4, 2016, 12:48 p.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128597/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2016, 12:48 p.m.)
>
>
> Review request for KDE Frameworks and Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> in the addapplet signal, support size paramenters as well, to specify a full geometry where you want the plasmoid.
>
>
> Diffs
> -----
>
> src/scriptengines/qml/plasmoid/containmentinterface.h 8236105
> src/scriptengines/qml/plasmoid/containmentinterface.cpp c390ad1
>
> Diff: https://git.reviewboard.kde.org/r/128597/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marco Martin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160804/a7065fd7/attachment-0001.html>
More information about the Plasma-devel
mailing list