Review Request 128599: Improve kpackage_install_package

Aleix Pol Gonzalez aleixpol at kde.org
Thu Aug 4 12:18:16 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128599/
-----------------------------------------------------------

Review request for KDE Frameworks and Plasma.


Repository: kpackage


Description
-------

* Make sure we don't just append to the regenerateindex.sh file but refresh it on every configure execution.
* Don't call generate every time when we configure. It's bound to break on systems that install in /usr.
* Use the KF5::kpackagetool5 imported target rather than trying to figure out where it went.


Diffs
-----

  CMakeLists.txt 312be78 
  KF5PackageMacros.cmake 81379c4 
  src/kpackagetool/CMakeLists.txt f0c40ee 

Diff: https://git.reviewboard.kde.org/r/128599/diff/


Testing
-------

Things now install properly.
The regenerateindex.sh files now make some sense.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160804/07b3a370/attachment.html>


More information about the Plasma-devel mailing list