Review Request 128552: Distinguish symlinks from other files in folder view plasmoid
Chinmoy Ranjan Pradhan
chinmoyrp65 at gmail.com
Thu Aug 4 10:55:56 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128552/
-----------------------------------------------------------
(Updated Aug. 4, 2016, 10:55 a.m.)
Review request for Plasma, Eike Hein and Marco Martin.
Changes
-------
Fixed the issues pointed out by Eike.
Repository: plasma-desktop
Description
-------
In folder view plasmoid symlinks and ordinary files look similar. This patch makes the symlink look different by italicising its name and adding an icon overlay.
Diffs (updated)
-----
containments/desktop/package/contents/ui/FolderItemDelegate.qml e4fcd67
containments/desktop/plugins/folder/foldermodel.h a6992bb
containments/desktop/plugins/folder/foldermodel.cpp 6abfb6b
Diff: https://git.reviewboard.kde.org/r/128552/diff/
Testing
-------
build
File Attachments
----------------
symlinks and other files/folders look similar
https://git.reviewboard.kde.org/media/uploaded/files/2016/07/29/7428b23d-03f9-4aed-8ca0-536d44e45e8c__beforepatch.png
after patch , everything looks fine
https://git.reviewboard.kde.org/media/uploaded/files/2016/07/29/040b2e3b-9ea0-4347-9e6c-ca3bdb73b36a__link.png
Thanks,
Chinmoy Ranjan Pradhan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160804/4bfee88e/attachment.html>
More information about the Plasma-devel
mailing list