Review Request 128597: support a size for adding applets

[Anthony Fieroni]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128597/#review98094
-----------------------------------------------------------




src/scriptengines/qml/plasmoid/containmentinterface.h (line 180)
<https://git.reviewboard.kde.org/r/128597/#comment66069>

    Isn't it better to be
    void appletAdded(QObject *applet, int x, int y, int width = -1, int height = -1);


- Anthony Fieroni


On Авг. 4, 2016, 1:32 след обяд, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128597/
> -----------------------------------------------------------
> 
> (Updated Авг. 4, 2016, 1:32 след обяд)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> in the addapplet signal, support size paramenters as well, to specify a full geometry where you want the plasmoid.
> 
> 
> Diffs
> -----
> 
>   src/scriptengines/qml/plasmoid/containmentinterface.h 8236105 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp c390ad1 
> 
> Diff: https://git.reviewboard.kde.org/r/128597/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160804/14fd1a02/attachment.html>