Review Request 128596: Define Plasma PackageStructure as regular KPackage PackageStructure plugins

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128596/#review98092
-----------------------------------------------------------


Ship it!




Ship It!

- Marco Martin


On Aug. 4, 2016, 9:55 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128596/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2016, 9:55 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This way we can use kpackagetool5 against them (see review 128590).
> 
> NOTE to the attentive reviewer:
> ShellPluginLoader wasn't properly ported. It's a class that is not adding anything to the plate now, using the base class works just as well and that can't be ported because now we have `KPackage::PackageStructure` rather than `Plasma::*`. Class left to maintain ABI but won't maintain behavior as is.
> 
> 
> Diffs
> -----
> 
>   src/plasma/CMakeLists.txt e9215c1 
>   src/plasma/containmentactions.cpp 3b9b76c 
>   src/plasma/package.cpp a3845b4 
>   src/plasma/packagestructure/CMakeLists.txt PRE-CREATION 
>   src/plasma/packagestructure/containmentactions-packagestructure.json PRE-CREATION 
>   src/plasma/packagestructure/containmentactionspackage.cpp PRE-CREATION 
>   src/plasma/packagestructure/dataengine-packagestructure.json PRE-CREATION 
>   src/plasma/packagestructure/dataenginepackage.cpp PRE-CREATION 
>   src/plasma/packagestructure/packages.cpp PRE-CREATION 
>   src/plasma/packagestructure/plasmageneric-packagestructure.json PRE-CREATION 
>   src/plasma/packagestructure/plasmagenericpackage.cpp PRE-CREATION 
>   src/plasma/packagestructure/plasmatheme-packagestructure.json PRE-CREATION 
>   src/plasma/packagestructure/plasmathemepackage.cpp PRE-CREATION 
>   src/plasma/packagestructure/plasmoid-packagestructure.json PRE-CREATION 
>   src/plasma/packagestructure/plasmoidpackage.cpp PRE-CREATION 
>   src/plasma/plasma.cpp a6da2d5 
>   src/plasma/pluginloader.cpp 6a9eb50 
>   src/plasma/private/packages.cpp 0392e8d 
>   src/plasma/private/packages_p.h 5c9dd7a 
>   src/plasma/theme.cpp e4a9e17 
>   src/plasmaquick/shellpluginloader.h d7e8079 
>   src/plasmaquick/shellpluginloader.cpp e660df9 
> 
> Diff: https://git.reviewboard.kde.org/r/128596/diff/
> 
> 
> Testing
> -------
> 
> Plasmashell still seems to work.
> Tests pass.
> A bunch of appdata files are installed from kdeplasma-addons.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160804/7872815c/attachment.html>