Review Request 128580: If we pass a QIcon as an argument to IconItem::Source, use it

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128580/
-----------------------------------------------------------

(Updated Aug. 3, 2016, 11:05 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
-------

Submitted with commit 812340ea2fc688da8c9b1ad23b33334676c83433 by David Edmundson to branch master.


Repository: plasma-framework


Description
-------

Currently the code gets the icon name from the QIcon and tries to do
some Plasma theming with it.
However if that fails it then loads the QIcon::fromTheme again.

This is pointless in most cases and will break any icons that have a
custom loader (all SNIs)


Diffs
-----

  src/declarativeimports/core/iconitem.cpp 29c7f05b5df060df7b362b331f7edc412df12307 

Diff: https://git.reviewboard.kde.org/r/128580/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160803/1ce7cd7e/attachment.html>