Review Request 128580: If we pass a QIcon as an argument to IconItem::Source, use it
David Edmundson
david at davidedmundson.co.uk
Tue Aug 2 21:11:03 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128580/
-----------------------------------------------------------
Review request for KDE Frameworks and Plasma.
Repository: plasma-framework
Description
-------
Currently the code gets the icon name from the QIcon and tries to do
some Plasma theming with it.
However if that fails it then loads the QIcon::fromTheme again.
This is pointless in most cases and will break any icons that have a
custom loader (all SNIs)
Diffs
-----
src/declarativeimports/core/iconitem.cpp 29c7f05b5df060df7b362b331f7edc412df12307
Diff: https://git.reviewboard.kde.org/r/128580/diff/
Testing
-------
Thanks,
David Edmundson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160802/e47e4c68/attachment.html>
More information about the Plasma-devel
mailing list