[Differential] [Request, 2 lines] D2338: [Kickoff] Fix start row for drag not always being correct

net147 (Jonathan Liu) noreply at phabricator.kde.org
Tue Aug 2 14:27:45 UTC 2016


net147 created this revision.
net147 added reviewers: broulik, Plasma.
net147 set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The start row for the drag is set to the current index but the current index is not always the item being dragged. This is because syncTarget has not been called yet to update the current index to the item under the cursor. Fix this by calling syncTarget before reading the current index.

TEST PLAN
  Drag items around and notice that the item being moved is not always correct.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2338

AFFECTED FILES
  applets/kickoff/package/contents/ui/FavoritesView.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: net147, broulik, #plasma
Cc: plasma-devel, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160802/50782ce8/attachment.html>


More information about the Plasma-devel mailing list