[Differential] [Requested Changes To] D2330: [xrandr backend] fall back to preferred mode, fix crash

graesslin (Martin Gräßlin) noreply at phabricator.kde.org
Tue Aug 2 14:19:38 UTC 2016


graesslin requested changes to this revision.
graesslin added a reviewer: graesslin.
graesslin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> xrandrconfig.cpp:556-558
> +    int modeId = modeId = xOutput->currentModeId().toInt();
> +    if (xOutput->currentModeId().isEmpty()) {
> +        modeId = kscreenOutput->currentMode() ? kscreenOutput->currentModeId().toInt() : kscreenOutput->preferredModeId().toInt();

I think you want to remove the if clause now

REPOSITORY
  rLIBKSCREEN KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D2330

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, dvratil, graesslin
Cc: graesslin, plasma-devel, #plasma, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160802/692ca0f7/attachment-0001.html>


More information about the Plasma-devel mailing list