[Differential] [Commented On] D2334: Respect the bottomPadding for the bottom of the drawer

mart (Marco Martin) noreply at phabricator.kde.org
Tue Aug 2 11:58:23 UTC 2016


mart added inline comments.

INLINE COMMENTS

> GlobalDrawer.qml:269
>                      Layout.alignment: Qt.AlignHCenter
> -                    Layout.minimumWidth: parent.width - Units.smallSpacing*2
> -                    Layout.maximumWidth: Layout.minimumWidth
> -                    Layout.preferredHeight: Layout.minimumHeight + Units.smallSpacing*2
> -                    Layout.fillWidth: false
> +                    Layout.leftMargin: Units.smallSpacing
> +                    Layout.rightMargin: Units.smallSpacing

leftovers from old patch

> GlobalDrawer.qml:310
>                      Layout.minimumWidth: Units.smallSpacing
> -                    Layout.minimumHeight: Units.smallSpacing
> +                    Layout.minimumHeight: root.bottomPadding
>                  }

this line is what the patch should be

REPOSITORY
  rKIRIGAMI Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D2334

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160802/5db17ecd/attachment.html>


More information about the Plasma-devel mailing list