Review Request 128573: Add overlay support to PlasmaCore::IconItem

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128573/#review97995
-----------------------------------------------------------




src/declarativeimports/core/iconitem.h (line 127)
<https://git.reviewboard.kde.org/r/128573/#comment66018>

    this is a list of strings, it should be overlays/setOverlays()



src/declarativeimports/core/iconitem.h (line 205)
<https://git.reviewboard.kde.org/r/128573/#comment66017>

    if it's a list, use plural for the name, m_overlays


- Marco Martin


On Aug. 2, 2016, 8:24 a.m., Chinmoy Ranjan Pradhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128573/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2016, 8:24 a.m.)
> 
> 
> Review request for Plasma and Eike Hein.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> As suggested in https://git.reviewboard.kde.org/r/128552/ (by Eike), this patch adds overlay support to IconItem.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/iconitem.h 6a1d67c 
>   src/declarativeimports/core/iconitem.cpp fae0330 
> 
> Diff: https://git.reviewboard.kde.org/r/128573/diff/
> 
> 
> Testing
> -------
> 
> build
> 
> 
> Thanks,
> 
> Chinmoy Ranjan Pradhan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160802/b6fc0b99/attachment.html>