Review Request 128573: Add overlay support to PlasmaCore::IconItem

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128573/#review97994
-----------------------------------------------------------




src/declarativeimports/core/iconitem.cpp (line 222)
<https://git.reviewboard.kde.org/r/128573/#comment66015>

    you're going to need some to signal that the icon needs to be redrawn
    
    otherwise if you set the overlay after the initial component is loaded it won't work.
    
    add "schedulePixmapUpdate()" somewhere in this method



src/declarativeimports/core/iconitem.cpp (line 472)
<https://git.reviewboard.kde.org/r/128573/#comment66016>

    why loop if we're going to use m_overlay every time?


- David Edmundson


On Aug. 2, 2016, 8:24 a.m., Chinmoy Ranjan Pradhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128573/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2016, 8:24 a.m.)
> 
> 
> Review request for Plasma and Eike Hein.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> As suggested in https://git.reviewboard.kde.org/r/128552/ (by Eike), this patch adds overlay support to IconItem.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/iconitem.h 6a1d67c 
>   src/declarativeimports/core/iconitem.cpp fae0330 
> 
> Diff: https://git.reviewboard.kde.org/r/128573/diff/
> 
> 
> Testing
> -------
> 
> build
> 
> 
> Thanks,
> 
> Chinmoy Ranjan Pradhan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160802/58103486/attachment.html>