[Differential] [Request, 22 lines] D2330: [xrandr backend] fall back to preferred mode, fix crash

[sebas (Sebastian Kügler)]

sebas created this revision.
sebas added a reviewer: dvratil.
sebas added a subscriber: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  When enabling outputs, it's possible that a KScreen::Output's current
  mode is empty. In this case, it's logical and necessary to fall back to
  the output's preferred mode, instead of passing essentially
  QString().toInt() as mode id into xcb_randr_set_crtc_config().
  
  In the current code, kscreenOuput->currentMode()->size() can crash, this
  is fixed with this patch as well.
  
  This change makes enabling a VGA monitor to my docking station more reliable.

TEST PLAN
  Connected, disconnted, reconfigured a tv connected via HDMI.

REPOSITORY
  rLIBKSCREEN KScreen Library

BRANCH
  sebas/modefallback

REVISION DETAIL
  https://phabricator.kde.org/D2330

AFFECTED FILES
  backends/xrandr/xrandrconfig.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, dvratil
Cc: plasma-devel, #plasma, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160802/a09669dd/attachment.html>