[Differential] [Request, 24 lines] D2328: Speed up loading KCM with FileDialog lazy loading

davidedmundson (David Edmundson) noreply at phabricator.kde.org
Mon Aug 1 22:05:50 UTC 2016


davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  FileDialog is very slow to load. Despite us using the platform theme is
  will also load the /entire/ fallback dialog in QML on startup; with
  tableviews and all, even though it obviously will never be shown.
  
  (See cbd0666 in QQC. It's apparently deliberate...though don't ask me to
  explain it.)
  
  As a bonus win, it works round a bug in TableView:
  https://bugreports.qt.io/browse/QTBUG-54752 which can crash.

TEST PLAN
  "time kcmshell5 desktoptheme" a few times shows 0.9 seconds of CPU time
  Clicking the install button still works.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2328

AFFECTED FILES
  kcms/desktoptheme/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160801/e1dfca79/attachment.html>


More information about the Plasma-devel mailing list