[Differential] [Request, 5 lines] D2325: Don't unconditionally emit buttonPressed on profile load

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added reviewers: Plasma, afiestas.
broulik set the repository for this revision to rPOWERDEVIL Powerdevil.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  A button press (technically the "lid closed" event is also a button press) should always be some consicious action triggered by the user. By emitting this signal unconditionally on profile load (ie. whenever changing an activity or (un)plugging AC) the session might always lock or suspend when this happens.
  
  If and only if a profile would really like to take some action or set some state depending on the lid state on profile load - which none do, the handle button press action should only react on explicit button presses anyway - it can still ask the backend for isLidClosed in its onProfileLoad method.
  
  BUG: 366125
  FIXED-IN: 5.7.4

TEST PLAN
  Closed the lid, still suspends. I can't find any evidence about the reason this was put in there in the first place.

REPOSITORY
  rPOWERDEVIL Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D2325

AFFECTED FILES
  daemon/powerdevilcore.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, afiestas
Cc: plasma-devel, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160801/b29b50e0/attachment.html>