Review Request 128526: Make BINARY_ICONS_RESOURCE ON by default

[Andreas Kainz]

> On Juli 27, 2016, 12:01 nachm., Jarosław Staniek wrote:
> > Update: the script of build.kde.org sets BINARY_ICONS_RESOURCE to ON, nevertheless everyone who compiles breeze-icons needs to know it's needed. It's hard to say not buiulding the rcc files gives any important optimization. The cost is like 10MiB for white and 10MiB for dark file while build dir of a single app is measured in GiBs.

Hi,
I can't reply any technical stuff. in the future I will only shipp breeze icons cause the breeze icons will be styles for breeze-dark. and in general I updated ALL icons to reduce the file size to a minimum that you can use them on windows, osx, ...


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128526/#review97865
-----------------------------------------------------------


On Juli 26, 2016, 9:35 vorm., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128526/
> -----------------------------------------------------------
> 
> (Updated Juli 26, 2016, 9:35 vorm.)
> 
> 
> Review request for Plasma and Andreas Kainz.
> 
> 
> Repository: breeze-icons
> 
> 
> Description
> -------
> 
> Make BINARY_ICONS_RESOURCE ON by default. Otherwise packagers will not create packages with breeze-icons.rcc. Let them possible create split packages - 1 with icon files and 1 with the rcc file.
> 
> Also our Jenkins fails to create the file, apps have no way to add dependency on breeze-icons "with rcc", there's just breeze-icons that we can depend on.
> Example failure: https://build.kde.org/job/kexi%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/lastFailedBuild/console
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt c0623ca 
> 
> Diff: https://git.reviewboard.kde.org/r/128526/diff/
> 
> 
> Testing
> -------
> 
> breeze-icons now installs the .rcc file.
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160801/e4442517/attachment-0001.html>