Review Request 127796: [SortFilterModel] Introduce limit and offset

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127796/#review95044
-----------------------------------------------------------



-1. Limiting+ sorting won't work properly.

You're using source row to limit , but that's pre filter/sort.

- David Edmundson


On April 30, 2016, 6:30 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127796/
> -----------------------------------------------------------
> 
> (Updated April 30, 2016, 6:30 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This allows to limit the number of entries in the model and specify an offset, useful for expandable lists and pagination. Comes with a unittest.
> 
> 
> Diffs
> -----
> 
>   autotests/sortfiltermodeltest.h e918fb0 
>   autotests/sortfiltermodeltest.cpp da0e393 
>   src/declarativeimports/core/corebindingsplugin.cpp e2b3a68 
>   src/declarativeimports/core/datamodel.h f43737c 
>   src/declarativeimports/core/datamodel.cpp 06b64e4 
> 
> Diff: https://git.reviewboard.kde.org/r/127796/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160430/c6f0b653/attachment.html>