Review Request 127793: kuiserver: use QApplication rather than QCoreApplication

Rex Dieter rdieter at gmail.com
Fri Apr 29 16:33:30 UTC 2016



> On April 29, 2016, 4:27 p.m., David Edmundson wrote:
> > Which part of ProgressListModel uses a UI?
> 
> Rex Dieter wrote:
>     Good question, I was largely just parot'ing comments from bug #348123 about this proposed patch, I'll go digging.

Further detail from the bug in question in case it helps:  
The attached patch fixes the 'lingering kuiserver processes after logout' issue. In debugging this I found that when using QCoreApplication, the kuiserver was not being properly terminated and the associated dbus service never unregistered.


- Rex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127793/#review95026
-----------------------------------------------------------


On April 29, 2016, 4:23 p.m., Rex Dieter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127793/
> -----------------------------------------------------------
> 
> (Updated April 29, 2016, 4:23 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 348123
>     https://bugs.kde.org/show_bug.cgi?id=348123
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> As GUI elements are present in ProgressListModel, use QApplication
> rather than QCoreApplication to ensure a GUI eventloop.
> 
> 
> Diffs
> -----
> 
>   kuiserver/main.cpp 3cc118a 
> 
> Diff: https://git.reviewboard.kde.org/r/127793/diff/
> 
> 
> Testing
> -------
> 
> plasmashell still functions normally, and kuiserver now properly exists at session end.
> 
> 
> Thanks,
> 
> Rex Dieter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160429/ee0dc7b7/attachment.html>


More information about the Plasma-devel mailing list