Review Request 127789: Media Controller: Fix playing next/previous song seeking

Kai Uwe Broulik kde at privat.broulik.de
Fri Apr 29 13:11:07 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127789/#review95018
-----------------------------------------------------------


Fix it, then Ship it!




Lgtm, thanks

It probably still sends a seek command but at least now it no longer sends one to the middle of the file :)


applets/mediacontroller/contents/ui/ExpandedRepresentation.qml (line 282)
<https://git.reviewboard.kde.org/r/127789/#comment64496>

    Please just write "Bug 1234" without the hash sign
    And space after //


- Kai Uwe Broulik


On April 29, 2016, 1:06 nachm., Rajeesh K V wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127789/
> -----------------------------------------------------------
> 
> (Updated April 29, 2016, 1:06 nachm.)
> 
> 
> Review request for Plasma and Kai Uwe Broulik.
> 
> 
> Bugs: 362473
>     https://bugs.kde.org/show_bug.cgi?id=362473
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Seems the Slider value is not reset when Next/Previous buttons are pressed in Media Controller widget. This causes next/previous song to seek the slider position instead of starting from beginning.
> 
> 
> Diffs
> -----
> 
>   applets/mediacontroller/contents/ui/ExpandedRepresentation.qml 628e08a 
> 
> Diff: https://git.reviewboard.kde.org/r/127789/diff/
> 
> 
> Testing
> -------
> 
> Tested against 5.6.2, on local system.
> 
> 
> Thanks,
> 
> Rajeesh K V
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160429/de1b7b7b/attachment.html>


More information about the Plasma-devel mailing list